jasmine / jasmine-gem

Jasmine ruby gem
682 stars 274 forks source link

Rake jasmine:ci fails does not run any specs on Phantomjs 2.0.0 #244

Closed nsong-ti closed 9 years ago

nsong-ti commented 9 years ago

I've seen mixed messages about whether Phantomjs 2.0.0 is actually supported. Using Phantomjs 1.9.8 and Jasmine 2.3.0, everything runs fine.

Switching to Phantomjs 2.0.0, the jasmine server starts up, and I see the Phantomjs process running in 'top', but no specs are run. No errors in the output either.

slackersoft commented 9 years ago

We haven't testing the jasmine:ci rake task with phantom 2.0, but I would have expected it to probably work.

The way it works right now is:

From what I can tell, all of this is still supported in phantom 2.0, and it doesn't look like the interfaces have changed.

I'd be happy to review a pull request that made the jasmine gem work with phantom 2.0, without breaking support for 1.9.x.

PatrickKing commented 9 years ago

It looks like PhantomJS 2.0.0 handles arguments a little bit differently. I was able to get my specs running with some minor changes to the javascript the gem hands to phantom, will see if I can get a pull request in soonish.