jasmine / jasmine-gem

Jasmine ruby gem
682 stars 274 forks source link

Resolve problem with Phantom 2.0.0 #245

Closed PatrickKing closed 9 years ago

PatrickKing commented 9 years ago

As reported, Jasmine currently hangs when run with Phantom 2.0.0, here's a patch to fix it. I tested this with Phantom 1.9.8, and then with Phantom 2.0.0, and everything passed.

The 'official' PhantomJS gem has not updated to 2.0.0 yet, so to run the tests against 2.0.0 I added: gem 'phantomjs', :github => 'PatrickKing/phantomjs-gem' to the Gemfile, which points to a version of phantom that I have personally hacked together to get 2.0.0 into my own projects. You should probably not use this gem. I have not included this change in the pull request.