search

jasmine / jasmine-gem

Jasmine ruby gem
682 stars 275 forks source link

Make versions correct? #258

Closed sashaegorov closed 8 years ago

sashaegorov commented 8 years ago

Hi, The first change is about syncing versions of jasmine-gem and jasmine-core. I think, making versions equal may help to avoid this kind of frustration:

$ gem install jasmine
Fetching: phantomjs-1.9.8.0.gem (100%)
...
Successfully installed jasmine-2.4.0
3 gems installed

This has fetched the following:

$ gem list | grep jasmine
jasmine (2.4.0)
jasmine-core (2.4.1)

bundler has exactly the same behavior.

Second. I'm not sure about it. ~> 2.4 replaced by >= 2.4.1 due to this. Is it reasonable to force a user to install version greater than 2.4.1 in order to avoid 2.4.0 which has breaking changes?

slackersoft commented 8 years ago

The current versioning strategy for jasmine it to rev everything together when there is a larger (i.e. major version or minor version bump), but then allow the patch version to be used independently by jasmine-core and jasmine-gem to indicate smaller bug fix type changes. This means that a bump for jasmine-gem to 2.4.1 all by itself is unwarranted, and the bump on the jasmine-core requirement doesn't seem necessary, since doing a bundle update jasmine or a fresh bundle install should both install the most current version of jasmine-core currently available.

Thanks for using Jasmine! Closing.

sashaegorov commented 8 years ago

@slackersoft, I've got it. Thanks for the explanation.