search

jasmine / jasmine-gem

Jasmine ruby gem
681 stars 275 forks source link

Force jasmine run to fail if any uncaught errors occur. #262

Closed rjomada closed 8 years ago

rjomada commented 8 years ago

This seems like a similar issue as this:

https://github.com/jasmine/jasmine/issues/326

To reproduce, you can introduce a compilation error in any spec and then rake jasmine:ci.

describe "the problem", ->
  beforeEach ->
    generatesCompileError 'there should be a comma after this argument' ->
      'this error will skip the entire spec file without reporting an error and succeeding, the only indicator is the number of tests run."

We were using jasmine 2.3.1 and upgraded to 2.4 to try to fix this, but it was still around.

roooodcastro commented 8 years ago

+1 for this.

I just spent an hour trying to figure out why my ES6 specs were working when I ran rake jasmine, but didn't even seem to load when I tried using rake jasmine:ci.

Jasmine should at least warn me of this instead of just swiping it under the rug and ignoring the files altogether.

slackersoft commented 8 years ago

This looks like a duplicate of jasmine/jasmine#529 and something that needs to be handled in the core library. Closing this. Thanks for using Jasmine!