search

jasmine / jasmine-gem

Jasmine ruby gem
682 stars 275 forks source link

Handle empty jasmine_done messages. #265

Closed jaredjenkins closed 8 years ago

jaredjenkins commented 8 years ago

jasmineDone appears to no longer pass a data parameter: http://jasmine.github.io/2.1/custom_reporter.html#section-jasmineDone

jaredjenkins commented 8 years ago

Would love to test this with a spec but I am not sure where I should start. Any thoughts?

slackersoft commented 8 years ago

I think we actually added the details to jasmineDone in the 2.5 release and the code in the Jasmine Gem was there to handle that going forward. The 2.5.x jasmine gem should rely on 2.5.x or greater of jasmine-core which will always include the run details.

I'm going to close this, but please let us know if you're still encountering the error in 2.5. Thanks for using Jasmine!