search

jasmine / jasmine-gem

Jasmine ruby gem
682 stars 274 forks source link

Too optimistic jasmine-core dependency #271

Closed himdel closed 7 years ago

himdel commented 7 years ago

Jasmine gem 2.4.1 depends on jasmine-core ~> 2.4 which means it's using 2.5.0 now. The correct dependency would be ~> 2.4.0.

The same problem is present in master..

slackersoft commented 7 years ago

Are you seeing incompatibilities when spanning versions like this? The intent with the versioning has been more to ensure that your Jasmine-Core version updates when you upgrade your Jasmine gem dependency.

Unfortunately, due to how these releases work, we can't change the dependency for the already released 2.4.1, but we can look into this again and see about locking the versions together more.

himdel commented 7 years ago

Yes, the main issue is that jasmine-core 2.5.0 no longer works in any version of phantomjs there's a gem for :).

Given that, I think it may even make sense to do a 2.4.2 release that just forces jasmine-core to 2.4.. but up to you, we've since fixed by explicitly depending on jasmine-core as well..

slackersoft commented 7 years ago

Jasmine 2.5.1 should fix the issues with phantomjs that popped up in 2.5.0. For right now, we don't have any plans to change the version interdependencies we have right now.

Closing this. Thanks for using Jasmine!

himdel commented 7 years ago

Allright, @slackersoft, thanks anyway :) As long as you know that when jasmine 2.6.0 comes out, jasmine-gem 2.5.0 will start bringing that one in, I'm OK with that, we'll just keep the explicit jasmine-core dependency then.