search

jasmine / jasmine-npm

A jasmine runner for node projects.
MIT License
377 stars 145 forks source link

Replace startsWith for indexOf #144

Closed styfle closed 5 years ago

styfle commented 5 years ago

It looks like PR #128 unintentionally broke compatibility with older versions of Node. So I changed it to a more compatible solution.

slackersoft commented 5 years ago

What version of Node.js are you seeing errors on? We run our tests against Node v4.x and above on Travis. My understanding from the node.js release schedule indicates that Node.js versions before that are no longer receiving updates, and folks are encouraged to update.

However, it does look like we didn't do a very good job in defining the supported engines in our package.json. If this is truly the only thing we need to change in Jasmine to support older versions of Node, it is probably worth it, but I'm concerned that supporting older versions could turn into a rabbit hole.

styfle commented 5 years ago

Yep, totally understand. We are at that point too with marked (see linked issue above).

I believe string.startsWith was introduced in Node v4.0.0 and our CI still runs v0.10 which was working fine until today 😃

I’ll continue discussion with marked team to see how soon we can deprecate 0.10 because right now, all builds are red ❌

slackersoft commented 5 years ago

Closing this, since it looks like the issue has been resolved. Please let me know if this is incorrect.