Breaking changes introduced as patch changes

jasmine / jasmine-npm

A jasmine runner for node projects.

MIT License

376 stars 145 forks source link

Breaking changes introduced as patch changes #174

Closed fastman closed 3 years ago

fastman commented 3 years ago

Hi, 3.6.1 didn't have engines in package.json specifying which versions of Node.js are supported. 3.6.2 version breaks compatibility with previously working versions of Node.js. 3.6.3 version specifies which versions of Node.js are support but up to 3.6.1 multiple versions, apart from the one listed in pacakge.json were supported. Shouldn't this be a breaking change?

sgravrock commented 3 years ago

I've removed the engines specification because, as you note, it was a breaking change for some users. For the rest, please see my comment in #166.

See https://jasmine.github.io/setup/nodejs.html for the list of supported Node versions. Note that odd-numbered versions are not supported. They're very likely to work at least until the next major release of Jasmine, but we can't offer compatibility guarantees for releases that have such a short lifespan.