search

jasmine / jasmine-npm

A jasmine runner for node projects.
MIT License
376 stars 145 forks source link

Should `jasmine init` include `.mjs` in output? #176

Closed jakub-g closed 3 years ago

jakub-g commented 3 years ago

When doing jasmine init it reads an example file: https://github.com/jasmine/jasmine-npm/blob/main/lib/command.js#L143

which currently puts "**/*[sS]pec.js" to spec_files: https://github.com/jasmine/jasmine-npm/blob/a91e8d4a97a4241ab04cc531ebfe917c618a208c/lib/examples/jasmine.json#L4

I'm wondering if it should output "**/*[sS]pec.(m?)js" now since jasmine supports mjs? WDYT?

(Also, perhaps the docs should be updated: https://jasmine.github.io/setup/nodejs.html#using-the-library)

sgravrock commented 3 years ago

That sounds good. I'd be happy to review a pull request that makes that change.