search

jasmine / jasmine-npm

A jasmine runner for node projects.
MIT License
376 stars 145 forks source link

Change addHelperFiles() call to addMatchingHelperFiles() #198

Closed lucaswerkmeister closed 2 years ago

lucaswerkmeister commented 2 years ago

addHelperFiles() was removed in 28f9495544. Fixes #197.

lucaswerkmeister commented 2 years ago

Not sure why CI is failing, it seemed to work locally.

sgravrock commented 2 years ago

Thanks for the PR.

I'm not sure why the tests pass for you. I get the same errors locally as on CI:

% npm test

> jasmine@4.2.0 test
> node ./bin/jasmine.js

Randomized with seed 59312
Started
..............................................................................................................................................................F...F.............................

Failures:
1) command running specs should be able to add one helper pattern
  Message:
    TypeError: jasmine.addMatchingHelperFiles is not a function
  Stack:
        at runJasmine (/Users/steve/src/jasmine/jasmine-npm/lib/command.js:143:13)
        at async Command.run (/Users/steve/src/jasmine/jasmine-npm/lib/command.js:56:9)
        at async UserContext.<anonymous> (/Users/steve/src/jasmine/jasmine-npm/spec/command_spec.js:245:7)

2) command running specs should be able to add many helper patterns
  Message:
    TypeError: jasmine.addMatchingHelperFiles is not a function
  Stack:
        at runJasmine (/Users/steve/src/jasmine/jasmine-npm/lib/command.js:143:13)
        at async Command.run (/Users/steve/src/jasmine/jasmine-npm/lib/command.js:56:9)
        at async UserContext.<anonymous> (/Users/steve/src/jasmine/jasmine-npm/spec/command_spec.js:250:7)

192 specs, 2 failures
Finished in 1.382 seconds
Randomized with seed 59312 (jasmine --random=true --seed=59312)

The issue is that the fakeJasmine defined in command_spec.js has an addHelperFiles method rather than the addMatchingHelperFiles defined by the real thing.

lucaswerkmeister commented 2 years ago

Sorry, I meant that I edited the file in node_modules/ and then the real CLI seemed to work – I didn’t realize the unit tests have a mocked method. I’ll look into updating the tests as well.