search

jasmine / jasmine-npm

A jasmine runner for node projects.
MIT License
376 stars 145 forks source link

`--require` fails with `runner.addRequires is not a function` in 5.x #208

Closed mattem closed 1 year ago

mattem commented 1 year ago

When running with --require (as done in rules_jasmine for Bazel), the error runner.addRequires is not a function is thrown.

It seems this was renamed to addRequires_ here: https://github.com/jasmine/jasmine-npm/blob/d0b93c46c95445aee2c478d1868a23140134ffcd/lib/runner_base.js#L337

But still called via addRequires here: https://github.com/jasmine/jasmine-npm/blob/d0b93c46c95445aee2c478d1868a23140134ffcd/lib/command.js#L193

sgravrock commented 1 year ago

This is fixed in 5.0.2.