Docs: Consistent Helpers Examples

jasmine / jasmine.github.io

Source for Jasmine's documentation

https://jasmine.github.io

MIT License

567 stars 418 forks source link

Docs: Consistent Helpers Examples #121

Closed 0x-2a closed 2 years ago

0x-2a commented 5 years ago

The react_with_npm doc has conflicting examples for helpers, and this PR makes them all the same:

"helpers/babel.js",
"helpers/**/*.js"

And this in the other:

"../spec/helpers/babel.js",
"../spec/helpers/**/*.js"

slackersoft commented 5 years ago

I think those are actually supposed to be different, since they are operating out of different base folders. It might make sense to give a bit more context in the earlier ones that the spec_dir is set to "spec" instead of "src" as it is later.

sgravrock commented 2 years ago

Closing due to inactivity and because the existing paths are correct. Thanks for your contribution. If you have ideas for how to make the reason for the different paths more obvious, feel free to open another PR or an issue with your suggestion.