search

jasmineRepo / JAS-mine-core

JAS-mine maintains and develops the JAS simulation platform, a discrete-event tool-kit for agent-based and dynamic microsimulation modelling. This repository contains the core libraries. See www.jas-mine.net for more details.
2 stars 5 forks source link

Typo in RegressionUtils multinomial bootstrap #5

Closed pbronka closed 4 years ago

pbronka commented 4 years ago

The method to bootstrap coefficients in case of a Multinomial Probit/Logit regression is called boostrapMultinomialRegression (While for other regression models it's bootstrap) which seems to be a typo. If it is, I was wondering if there might be a way to change that without affecting existing models that possibly use this method?

rer98 commented 4 years ago

Hi pbronka, Thanks a lot for letting me know - yes, it is a typo! I've addressed this issue by renaming the method to the correct 'bootstrapMultinomialRegression'. I've also addressed the issue of backwards compatibility by introducing a (deprecated) method with the old name, which just calls the new method. Many thanks again and let me know if you have any further issues! Best wishes, Ross

pbronka commented 4 years ago

Hi Ross, That's great, thanks a lot for getting back to me so quickly and fixing it! Best wishes, Patryk