Display the date of each challenge completed in `index.html`

jasminexie / 100-days-css

100 Days of CSS challenge with Parcel, PostCSS and Pug.

The Unlicense

12 stars 7 forks source link

Display the date of each challenge completed in `index.html` #2

Closed jasminexie closed 4 years ago

jasminexie commented 4 years ago

In the main index.html, I'd like to display the date of each challenge completed, and their author. I have a few ideas:

Read all git commit messages in the pre-commit hook. Since commit messages are mostly feat: ${challenge-id}, it wouldn't be difficult to parse the challenge name, commit date, and author id/email.
Modify the structure of the existing config.json, and change how the Vue component reads config.json. We can do something like this:

config.json
```
[{
  "id": "012",
  "author": "jasminexie"
  "date": "09/01/2019"
}]
```
and display these details on the index page.

guesant commented 4 years ago

The date is in DD/MM/YYYY or MM/DD/YYYY?

guesant commented 4 years ago

@jasminexie I believe I can help you with this issue. Can I work on this?

jasminexie commented 4 years ago

@jasminexie I believe I can help you with this issue. Can I work on this?

Great. I'll assign this to you.

The date format isn't very important - where I live it's usually MM/DD, but anything universally understood is OK. Since I'm currently the only person working on the repo, if you take a look at the git log you could probably see that all commit messages are somewhat consistent.

(If we're going to do this, we could try and enforce the feat: ${challenge-id} style commit message in a pre-commit hook. Just a thought.)

I haven't thought too much about the implementation, so if you want to work on this you have a LOT of freedom.

guesant commented 4 years ago

Oh thanks!

Do you have a style for this information in mind? If you want I can send you some suggestions

jasminexie commented 4 years ago

Oh thanks!

Do you have a style for this information in mind? If you want I can send you some suggestions

All suggestions are welcome 👍

What do you mean by styles? If you're referring to the styling and layout of the final result - anything clear and consistent is fine. I've used element-ui; you're welcome to adopt another UI library or write your own styles.

guesant commented 4 years ago

Yeah, i mean style like design/layout of the information about author and date. I'm not fluent in english, sorry 😅🙃.

It's amazing the CSS work you did 👏👏👏. I will soon accept the "100 Days of CSS" challenge using this project as the results manager 😁

I've been thinking of something simple, like this:

op1 op2

What do you think about it?

jasminexie commented 4 years ago

I've looked at the code and you've done a really good job. It's nice to see such a high-quality contribution 😄

Both styles look good! I personally like the second one better. I'll be happy to merge this once Hacktoberfest begins.