Closed zloirock closed 7 years ago
isInt64
and isUint64
back out.isStringIterator
tho I'm not sure we've seen any significant reason to call that one out in Node.js. Not sure there's much of a use case for it.isGeneratorObject()
... it could go on Object
I suppose.[TypedArray]
methods. would like to have a better place to hang those off. Perhaps just make them specific... Uint8Array.isUint8Array(arg)
, Uint16Array.isUint16Array(arg)
would be best...Intl
stuff... wanted to include those here for completeness but can engage with 402 directly on those.Updated to address this feedback
👍
String.isStringIterator
required for consistancy with other methods.isTypedArray
also should be moved... maybe to Object
?Will add isStringIterator()
. Will deal with the location of isTypedArray
separately.
Set.isSharedArrayBuffer
?O_oNumber.isSafeInteger
, so addingNumber.isInt64
andNumber.isUint64
seems wrong.String.isStringIterator
?isGeneratorObject
should be inFunction
namespace?isTypedArray
andis(Int|Uint)(8|16|32|64)Array
methods to[TypedArray]
(%TypedArray%
?) seems wrong -Uint8Array.isTypedArray(float32array)
orFloat32Array.isUint8Array(uint8array)
confuses.Intl
is not a part of ECMA262, so adding methods to it should be a proposal for ECMA402.