search

jason-fox / fox.jason.passthrough.pandoc

Pandoc DITA-OT Plug-in for extending the available input formats for DITA-OT. Non DITA input sources can be pre-processed to create create valid DITA source.
https://jason-fox.github.io/dita-ot-plugins/pandoc
Apache License 2.0
20 stars 4 forks source link

[new] unify pandoc exec call #6

Open thendarion opened 3 years ago

thendarion commented 3 years ago

it was weird that pandoc was called differently on windows and linux even though it was passed the same exact parameters, so here's a proposal to use the same call on both platforms

thendarion commented 3 years ago

not sure what happened there. sonarcloud didn't even run?

jason-fox commented 3 years ago

Have you tested this on Windows? The reason for the current split is because the ANT exec task is doing different things in Windows and Unix - Windows is spawning a command shell, Unix isn't.

jason-fox commented 3 years ago

not sure what happened there. sonarcloud didn't even run?

It is to do with the GitHub Action setup. Sonar Cloud requires the ${{ secrets.SONAR_CLOUD_LOGIN }} which is set up in the repository settings. For some reason this secret hasn't been read in on the PR. Weird.

thendarion commented 3 years ago

unfortunately in my Windows 10 environment this change was necessary to make it work

jason-fox commented 3 years ago

unfortunately in my Windows 10 environment this change was necessary to make it work

Nothing like consistency eh? I'll need to find an environment do some Windows 7,8, 10 testing I guess.

jason-fox commented 3 years ago

Do the changes made for 162572bce0e9f3dd0741faeb4b164d9cb9753b37 (effectively allowing the user to supply a path to Pandoc) help resolve this issue?

thendarion commented 3 years ago

I'll check and get back to you