search

jason-green-io / papyri

Minecraft map item data mapping tool using Leaflet
MIT License
63 stars 9 forks source link

[Suggestion] Remove banners added to multiple maps appearing twice on leaflet #30

Open TheSabotender opened 3 years ago

TheSabotender commented 3 years ago

Banners added to multiple maps currently appear twice on leaflet.

Suggestion: Add a command line argument so that banners with identical X, Y, Z, name and dimension are only added once to the banners.json.

jason-green-io commented 3 years ago

In theory I agree, but what if the content of a banner is different on one of the maps because it hasn't been updated. Which is picked?

Edit: after thinking about it .. you're right .. why should it show the EXACT same banners twice. I don't think we need a command line argument, I'll make it the default.

MnTronslien commented 3 years ago

Hey, so I have an edge case to add to this!

I wanted to have an orange marker as the banner and not a plain white, so naturally, I took down the white and placed an orange banner in its place. I have since lost the map with the white banner on it, either through "upgrading it" misplacing it. image

How do we clean up old banners from maps that no longer exist because they have either been lost or "upgraded" to bigger maps? I don't know if it is any good ways to do this programmatically as papyrus don't know which maps are in use and which are not, so this might have to be done manually - in that case I wonder if anyone knows how.

jason-green-io commented 3 years ago

I plan on implementing which banners are on which maps in the map overlay. Then you'd know which map to delete to get rid of the banner. If you're not squeamish, you could also edit the map's nbt directly.

On Tue, Dec 29, 2020 at 14:00 MnTronslien notifications@github.com wrote:

Hey, so I have an edge case to add to this!

I wanted to have an orange marker as the banner and not a plain white, so naturally, I took down the white and placed an orange banner in its place. I have since lost the map with the white banner on it, either through "upgrading it" misplacing it. [image: image] https://user-images.githubusercontent.com/16963894/103307469-63d88b00-4a10-11eb-85b2-b7883679606c.png

How do we clean up old banners from maps that no longer exist because they have either been lost or "upgraded" to bigger maps? I don't know if it is any good ways to do this programmatically as papyrus don't know which maps are in use and which are not, so this might have to be done manually - in that case I wonder if anyone knows how.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/jason-green-io/papyri/issues/30#issuecomment-752205942, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVYU4J4PZJUXOKIRSFRALTSXIROFANCNFSM4UWADXXQ .

MnTronslien commented 3 years ago

I have just been deleting the offending maps from data, they are oftentimes lower scale version of maps that no longer have an in-game item referring them anymore. I don't know how to edit the nbt (or what kind of file it is).