search

jason-p-pickering / dhis2-persian-calendar

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Pivots fail to load the persian calendar #5

Open jason-p-pickering opened 7 years ago

jason-p-pickering commented 7 years ago

https://github.com/dhis2/d2-analysis/blob/master/src/manager/CalendarManager.js#L40

would seem to control where the Persian calendar is obtained from, but it does not seem to work properly.

brajja commented 7 years ago

Probably a small fix i adding 'persian' to line 17 (in CalenderManager.js): t.calendarIds = ['coptic', 'ethiopian', 'islamic', 'julian', 'nepali', 'thai'];

Have not been able to test locally yet. Can't link the packages as I'm used to. Probably a little more complex build process ;)

jason-p-pickering commented 7 years ago

I made a local changed to d2-analysis, and then copied over the result to node_modules for local testing.

brajja commented 7 years ago

Do you build it or anything like that

On May 23, 2017 12:17 PM, "Jason Pickering" notifications@github.com wrote:

I made a local changed to d2-analysis, and then copied over the result to node_modules for local testing.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jason-p-pickering/dhis2-persian-calendar/issues/5#issuecomment-303355133, or mute the thread https://github.com/notifications/unsubscribe-auth/ACXdAz12hqGHYK2FumuyQX6rDEuQMlFMks5r8rIbgaJpZM4NjXTF .

jason-p-pickering commented 7 years ago

nope. Just copied over the source from d2-analysis to node_modules/d2-analysis

brajja commented 7 years ago

OK - got to work when linked in with "npm link ../d2-analysis". Saw also the months on English, Then I throw the d2-analysis and pivot app away to redo everything clean but now I dont get i to wor. Someone update d2-analysis an hour ago or so... But this will probably work wit above fix. (English month is another issue of cours)