jason-roberts / FeatureToggle

Simple, reliable feature toggles in .NET
http://dontcodetired.com/blog/?tag=/featuretoggle
Apache License 2.0
689 stars 111 forks source link

FeatureToggle not compatible with ASP.NET 5/vNext #109

Closed DonDebonair closed 7 years ago

DonDebonair commented 8 years ago

I'm porting an ASP.NET 4.6 app to the net ASP.NET 5 & MVC 6, and it uses the FeatureToggle library. It seems however, that even though I'm installing it through Nuget, anything under the FeatureToggle.Core namespace cannot be found.

Should FeatureToggle be compatible with ASP.NET 5? Is it able to handle the new way of configuration?

jason-roberts commented 8 years ago

Thanks @DandyDev - not tested as yet but it will be supported in a future version

jason-roberts commented 8 years ago

Once ASP.NET Core 1.0 is RTM or close to support will be added, it's a bit too far out at this stage to doing the development.

aensidhe commented 8 years ago

They are close now, JFYI

Assassyn commented 8 years ago

ASP.NET Core is now RC2 and has the go live promise.

Will you accept the PR with netstandard code enabled?

jason-roberts commented 8 years ago

Hi @SzymonSasin - I'd still like to wait until v1 ships, I also am considering what v4 will look like - I'm assuming there will be no breaking changes by added support for core/asp?

Assassyn commented 8 years ago

I have tried and I am having some problems with referencing, that is a "missing System.Runtime" error.

In thery the .net core/standard dll should replace almost all of the "Code" projects. I think that Sql migth have to be taken outside similar to raven. otehr than that there should be no code changes.

jason-roberts commented 7 years ago

see #121