search

jason-roberts / FeatureToggle

Simple, reliable feature toggles in .NET
http://dontcodetired.com/blog/?tag=/featuretoggle
Apache License 2.0
689 stars 111 forks source link

Fix Convention tests that were failing because of compiler-generated … #112

Closed vermeeca closed 8 years ago

vermeeca commented 8 years ago

…nested inner classes.

When I cloned and tried to run tests, I noticed that a couple Unit Tests were failing because of some nested inner classes that the compiler generates. This fixes those tests.

vermeeca commented 8 years ago

I noticed that previous AppVeyor tests were all passing. So, the test failure could be because I'm using Visual Studio 2015.

FWIW, here's an example of the errors I saw:

`'Non-Toggle Base Classess must not be under the 'FeatureToggle.Toggles' namespace' for 'Types in FeatureToggle'

FeatureToggle.Toggles.EnabledBetweenDatesFeatureToggle+<>c
FeatureToggle.Toggles.EnabledOnDaysOfWeekFeatureToggle+<>c
FeatureToggle.Toggles.EnabledOnOrAfterDateFeatureToggle+<>c
FeatureToggle.Toggles.EnabledOnOrBeforeDateFeatureToggle+<>c

`

Where those are inner classes generated by the compiler, seemingly related to the NowProvider Func.

jason-roberts commented 8 years ago

thanks @vermeeca I'll be upgrading the solution to 2015 shortly :)

jason-roberts commented 8 years ago

Thanks for looking into this @vermeeca updating to latest ver of convention tests fixed part of problem https://github.com/TestStack/TestStack.ConventionTests/issues/54