search

jason-roberts / FeatureToggle

Simple, reliable feature toggles in .NET
http://dontcodetired.com/blog/?tag=/featuretoggle
Apache License 2.0
687 stars 111 forks source link

Remove installation of SampleFeatureToggle into the projects when installing via NuGet #117

Closed samholder closed 8 years ago

samholder commented 8 years ago

Whilst having a SampleFeatureToggle is a reasonable idea for people starting out, having this added to every project, every time you install/update the nuget package becomes annoying very quickly.

A model some other projects (essential diagnostics being one) follow is to have 2 nuget packages. One which just install the core libraries (FeatureToggle) and one which installs the samples and config examples (FeatureToggle.Config or FeatureToggle.Samples maybe). This allows the users the choice of whether they want to have the samples or not.

jason-roberts commented 8 years ago

Thanks @samholder - I agree - I will remove this for next release and consider the additional packages for future releases.

jason-roberts commented 8 years ago

Added #119 to capture idea for additional nugets

JakeGinnivan commented 8 years ago

This would be great, I am currently removing the sample feature toggle from about 20 projects because FeatureToggle is a transitive dependency so it got added everywhere :)

jason-roberts commented 8 years ago

Just doing this now. @JakeGinnivan do you think as far as semver is concerned you'd consider this a breaking change?

JakeGinnivan commented 8 years ago

Nope, it only happens during installation so it won't affect anyone existing.

jason-roberts commented 8 years ago

@JakeGinnivan yeah, that's kinda what I was thinking - thanks

samholder commented 8 years ago

Thanks! much appreciated!

jason-roberts commented 8 years ago

@samholder no worries