search

jason-roberts / FeatureToggle

Simple, reliable feature toggles in .NET
http://dontcodetired.com/blog/?tag=/featuretoggle
Apache License 2.0
689 stars 111 forks source link

No strong name for v. 3.5 #126

Closed voroninp closed 7 years ago

voroninp commented 7 years ago

I've updated NuGet package to v.3.5.0 and got the following error:

Error CS8002: Referenced assembly 'FeatureToggle, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

I do not understand why versions differ from NuGet package version.

jason-roberts commented 7 years ago

Hi @voroninp - from which version were you updating from?

voroninp commented 7 years ago

Pardon me, it was not signed earlier. My colleague did that... I updated from these versions, if you still need it =)

  <package id="FeatureToggle" version="3.2.0" targetFramework="net451" />
  <package id="FeatureToggle.Core" version="3.0.0" targetFramework="net451" />
jason-roberts commented 7 years ago

no worries @voroninp :)

voroninp commented 7 years ago

@jason-roberts Ok =) Do you mind if I make a PR with assemblies signing enabled?

jason-roberts commented 7 years ago

hi @voroninp , this is not something that will currently be supported, please see https://github.com/jason-roberts/FeatureToggle/issues/75 and https://github.com/jason-roberts/FeatureToggle/issues/124