jason-roberts / FeatureToggle

Simple, reliable feature toggles in .NET
http://dontcodetired.com/blog/?tag=/featuretoggle
Apache License 2.0
689 stars 111 forks source link

Change ConfigurationRoot to Configuration in AppSettingsProvider #159

Open CumpsD opened 6 years ago

CumpsD commented 6 years ago

In .NET Core 2.0 it is advised to switch to IConfiguration: https://docs.microsoft.com/en-us/aspnet/core/migration/1x-to-2x/?view=aspnetcore-2.0#add-configuration-providers

This means there is no IConfigurationRoot anymore to pass to AppSettingsProvider https://github.com/jason-roberts/FeatureToggle/blob/master/src/FeatureToggle.Shared/Internal/AppSettingsProvider.cs#L32

jason-roberts commented 6 years ago

Thanks @CumpsD - we'll look at this in v5