search

jason-roberts / FeatureToggle

Simple, reliable feature toggles in .NET
http://dontcodetired.com/blog/?tag=/featuretoggle
Apache License 2.0
689 stars 111 forks source link

SqlFeatureToggle is disabled for .NET Core. #164

Closed Wind010 closed 5 years ago

Wind010 commented 6 years ago

Is this due to non .NET Standard/Core dependencies?

Wind010 commented 6 years ago

Seems like there is just more work to be done when it comes to the BooleanSqlServerProvider and loading the connection string and query details.

mostafahedawa commented 5 years ago

Hi @Wind010 Are you found solution for this issue ? or if there is any update ?

Wind010 commented 5 years ago

I've committed changes to load up the AppSettings.*.json here: https://github.com/Wind010/FeatureToggle/tree/develop

Expects the following configuration: "FeatureToggle": { "SomeSqlServerToggle" : { "ConnectionString" : "Data Source=.\SQLEXPRESS;Initial Catalog=FeatureToggleIntegrationTests;Integrated Security=True;Pooling=False"" "SqlStatement" : "SELECT select Value from Toggles where ToggleName = 'MySqlServerToggleFalse'" } },

I haven't tested it nor written any unit-tests. I made the changes on a machine that I didn't want to install the Win10 SDK which is required to build the solution.