search

jason-roberts / FeatureToggle

Simple, reliable feature toggles in .NET
http://dontcodetired.com/blog/?tag=/featuretoggle
Apache License 2.0
689 stars 111 forks source link

Allow BooleanSqlToggle to share a single <connnectionStrings> named connection #96

Closed jason-roberts closed 9 years ago

jason-roberts commented 9 years ago

See #88 for more background

<connectionStrings>
    <add name="primary" connectionString="connection-string" />
</connectionStrings>

<appSettings>
    <add key="FeatureToggle.MyFeatureToggle.ConnectionStringName" value="primary" />
</appSettings>
craig-wagner commented 9 years ago

Just submitted a pull request (https://github.com/jason-roberts/FeatureToggle/pull/97) for this feature (with unit tests). This is the first time I've tried contributing. Followed the instructions on https://guides.github.com/activities/forking. Let me know if anything needs improvement.

jason-roberts commented 9 years ago

@craig-wagner - do you want to take a quick look at this https://github.com/jason-roberts/FeatureToggle/commit/d6a1564b80aea29a06bf1d854dc8f37837849370 just to check it's still operating as you expected? If all is well we can get v3.2 released this week :)

craig-wagner commented 9 years ago

@jason-roberts - Looks like it still works as I intended.