Add support for billable property

jason0x43 / alfred-toggl

Alfred Workflow for interacting with the Toggl time tracking service

MIT License

367 stars 16 forks source link

Add support for billable property #45

Closed blackjid closed 7 years ago

blackjid commented 7 years ago

Add the correct call to StartTimeEntryForProject passing the billable property. This way new time entries will use the default value for the project.
Adds the option to toggle the Billable property in the time entry options

This depends on https://github.com/jason0x43/go-toggl/pull/5 https://github.com/jason0x43/go-toggl/pull/6

blackjid commented 7 years ago

hi @jason0x43 I was thinking that I could use the Workspaces.Premium property to decide whether to show or not the Billable option. Let me know what do you think, to add it.

jason0x43 commented 7 years ago

Yeah, that makes sense. For actually using the property, the most consistent option is probably to add a getWorkspaceByID method to support.go (like all the other getXByID methods), and then get the workspace for the timer's project or task, or the user's current default workspace, and check its Premium flag when constructing the menu for a time entry.

blackjid commented 7 years ago

@jason0x43 hey, I updated the PR with the new feature we talked about.. :)

jason0x43 commented 7 years ago

Great! I'll take a look at it tonight or tomorrow.

jason0x43 commented 7 years ago

Squashed and merged in a0359a8