jason330 / GetTable

0 stars 0 forks source link

FSP Backend and Frontend Routes #3

Open mwmadsen67 opened 2 years ago

mwmadsen67 commented 2 years ago

Backend Routes


Frontend Routes

mwmadsen67 commented 2 years ago

Hi Jason, here are some notes on your routes:

Backend Routes:

Frontend Routes:

jason330 commented 2 years ago

Hi Mike!

Thanks for the feedback! I made some additions and also replied below your comments:

Hi Jason, here are some notes on your routes:

Backend Routes:

  • users and session and restaurants looks good

I added a GET /api/users/:user_id because I wasn't sure if I previously had a way to get the logged in user's reservations and reports.

  • for reservations and reports, remember that update and delete needs an id. ex: PATCH /api/bookings/:id

Thank you! Made the updates!

Frontend Routes:

  • I notice there's a user profile edit component, keep in mind that if you want to implement a profile edit that we consider that an extra feature aside from user auth, so you'd have to think if you'd want to make another currently planned feature a bonus feature instead, or if youd want profile edit to be a bonus feature.

I realized that user/profile/edit and ProfileComponent were not specific enough, so I changed them to better represent my intent: /reservations/:reservationId/edit rendering ReservationItem and AvailableTablesComponent.

  • I don't see any frontend route for restaurant index

The OpenTable home page has a search field and then just lists all restaurants by category, so I tentatively planned to render these components at the / route; I updated the components on the wiki.

Thanks again for your help!!