jasonLaster
commented
12 years ago This looks great. I agree with your thoughts on refactoring. The index page is the worst page cause it has gone through a lot of iterations. Refactoring is a great way too learn though so I'll leave it for you to ply with flyer flags. I have ideas for refactoring, but yea it'll one down to helpers, and actions taking logic out of the view and model methods taking logic out of the actions.
Just want to say it was great working with you today. You've really got a gift for this stuff. I look forward to hacking on this soon.
On May 13, 2012, at 12:52 AM, haplesshero13reply@reply.github.com wrote:
Implements issue #36 by showing search results for a particular query. Also fixes a typo in controller.
You can merge this Pull Request by running:
git pull https://github.com/jasonLaster/DGD 36-search-results
Or you can view, comment on it, or merge it online at:
https://github.com/jasonLaster/DGD/pull/37
-- Commit Summary --
- Add Group#search
- Group#search now returns list of all matching groups
- add search page
- Now ignoring sqlite journals
- Display search results and count if groups found, or directory and message if none found. Needs refactoring pretty badly.
- Prettified search results a little.
- Fixed typo: groups -> @groups
-- File Changes --
M .gitignore (2) M app/assets/stylesheets/global.less (16) M app/controllers/group_controller.rb (44) M app/models/group.rb (4) M app/views/group/index.html.haml (82) M spec/models/group_spec.rb (6)
-- Patch Links --
https://github.com/jasonLaster/DGD/pull/37.patch https://github.com/jasonLaster/DGD/pull/37.diff
Reply to this email directly or view it on GitHub: https://github.com/jasonLaster/DGD/pull/37
haplesshero13
Implements issue #36 by showing search results for a particular query. Also fixes a typo in controller.