Closed s-crypt closed 8 months ago
I recall a discussion from last year where the same issue came up. I thought most of the panels had been updated, but that may only have been done in alternative dashboards and not the main project dashboard.
Here is a dashboard with my versions of Solar Energy Year and Grid Status that use current panels. You should be able to import the dashboard and then copy the panels over into your dashboard. My setup has diverged a bit from the main project, so some tweaking may be needed after importing the panels.
I don't have a Savings panel to share.
Those panels work with no additional configuration! Thanks!
The solar energy year you provided did not have grid usage, so I added it, I also changed the lines to be staircase lines like the old graph.
I suppose all I would need is the savings panel and then I could make a pull request of the default dashboard with the new panels, though @jasonacox seems to be a grafana wizard so maybe he has some input.
Yes, I confess, I have been reluctant to do this for aesthetic reasons. We switched to the new time series graph for the main panel, but I found the grid lines to be annoyingly dim and untidy (bleed hanging lines without termination). I looked in to the code changes needed to adjust the grid lines and it isn't customizable (hardcoded) in Grafana. It is minor and if the majority of the community likes the new look we can update.
Old / New:
I knew it lol. I totally get the aesthetics reason (but weirdly I like the new grafana designs). Would you consider field testing a dashboard-new.json to see what people think and start a discussion post about it?
Yes of course! Feel free to submit a PR. I promise, I'll test drive it too. :)
I made a PR with most of the changes, except wind, pressure, and precip
and savings
in #295
Thanks @s-crypt ! I merged the change for anyone who wants to take a look it is here, dashboard-new.json.
There are a few minor issues or differences I would like to address:
I think I accidentally shared my personal dashboard lol. Ill make a PR with the correct one.
In #297 I believe I fixed the issues you brought up. I did not set the grid usage to have a y=0 because that would only show power draw.
Thanks, @s-crypt ! Looks better!
On the y=0, for all the grpahs that should be under the "soft min" section to display without clipping:
I just added soft-min = 0:
Also, it looks like "Wind, Pressure and Precipitation" graph can be migrated but you will need to push "Pressure" to "axis placement" = right.
I'm not a fan of the new pie-chart (which is why I have the plugin for the old one) but I'm happy to keep it in there for a consistent "all new" look. 😉
Thanks for the information! Its nice to learn about grafana. I have submitted the following changes in #298
Messing around with savings, there seems to be several issues when trying to convert savings to a bar chart. After changing many settings to replicate the first, there were some things that I could not figure out how to fix:
1) It sets the X axis to time with the query response time as the labels for the x axis 2) it shows only two lines for the axis 3) they are REALLY far apart and skinny.
Overall, I think the migration is an improvement for most of the panels. Thanks @s-crypt ! I for one, really appreciate your effort here.
I'm doing analysis of each to ensure we didn't lose anything in the migration before using this as our default dashboard for the project. There are some minor exceptions so far:
The "Self Powered" pie chart has been updated to continue to use the plugin. Others can optionally change it out for the "skinny tire" version.
The "Current State" had some color changes that I am trying to figure out - I'll confirm they still meet the project color palette ( existing / new ):
The new graph was missing the grid synchronization (-1) phase of grid status. I added that and also converted the dots to bars to create a more obvious off-grid signal:
Wow I didn't know it would be the default dashboard. That's cool!
Regarding your comments:
I believe I was able to successfully migrate the savings panel to a bar chart in #314
Please let me know if you have any comments or questions! The PR also reverts the color changes in current state as those are a separate issue/comment.
I made 2 more changes to the default:
If you think it is appropriate, I have created #315 to migrate the savings panel on the default dashboard, along with fixing some sizing issues where the savings and self powered were too small on both default and new, and undid my janky tab spaced json for dashboard-new.
If you decide to merge that PR, I don't think that dashboard-new is necessary anymore, but I would love to hear what you think!
Great catch on the "estimated savings" calc miss (was using hard coded 0.19 instead of variables)!! I made that change to the default.
I'm not quite ready to accept the migrated savings graph. I need to tweak it a bit more to see why it bugs me. However, I do want to merge your dashboard-new.json changes. Can you remove the dashboard.json changes for now?
FYI - old / migrated savings:
Sounds good! I made those changes and a small fix in dashboard.json in #316
I'm a bit embarrassed that I'm so high maintenance 😊, but I like the row symmetry provided by h=5 rather than h=6 for the old graph:
h = 5
h = 6
alright, undid that change. I thought I shortened the height accidentally a while ago.
On almost all the graphing panels grafana suggests migration for "more capability and better performance".
Would it be possible to update the default dashboard to contain these new panel charts?
Several of these are available to migrate with one click (and changing line width to 0 or fiddling for less than a minute to replicate the old chart). Most of the changes are from the panel types
Graph (old)
toTime series
.These are
* = do not have data for and cannot verify a simple migration, but it's likely
There are also a couple panels where automatic migration is not good, but grafana still reccomends migration
I have noticed an increase in performance (running on a raspberry pi) as opposed to the old chart type. I found it easy to migrate the chart types in the first list, but Grid Status, Savings, and Solar Energy Year stumped me as I am a grafana newbie.