Open stef-ladefense opened 2 years ago
I love it! ❤️ You are absolutely right. This is more intuitive.
Do you want to submit a pull request with your changes? I can make the change myself but would prefer if you get the credit.
thank ❤ voila !
Thank you! This is a great upgrade! This will be part of release v1.6.0, coming soon.
v1.6.0 Released: https://www.arduino.cc/reference/en/libraries/tm1637tinydisplay/
You code is now live. Thanks for your contribution and help!
I noticed that in the code, when you change the brightness or simply turn off the display, you have to do a setBrightness followed by rewriting the message. It's counterproductive. If for example I want to flash the display, at worst I have to do either:
or better not using setBrightness but rewriting the message all the same
By simply moving the writing of the TM1637_I2C_COMM3 into the setBrightness, the command becomes instantaneous and allows the brightness to be varied or the display to be turned off or on without rewriting a message after the setBrightness. this command doesn't need anything else to work.
change in TM1637TinyDisplay.cpp
tested on my current project and works without any observed side effects. What do you think ?
Stephane