jasonacox / pypowerwall

Python API for Tesla Powerwall and Solar Power Data
MIT License
120 stars 21 forks source link

Adding alternate alerts when vitals not present #75

Closed DerickJohnson closed 3 months ago

DerickJohnson commented 3 months ago

This will utilize the /api/solar_powerwall endpoint to populate the alerts array if devices (through vitals) are not present. Let me know if you want it simplified to not include the outer 'if'. I included it for clarity, to show the distinct paths, but it can also be simplified if needed (since it won't loop through devices that aren't present).

I also only used the fallback if alertsonly was true, since we don't have device specific information in that setup.

This should be automatically picked up by the alerts/pw endpoint since the format is the same.

I tested it locally using the /alerts endpoint, but might be good to validate that it still uses vitals if they are present (it should). I am on the later firmware where it's no longer present (23.44).

Let me know if you'd like anything changed!

DerickJohnson commented 3 months ago

Let me add some error handling actually, in case that endpoint goes

DerickJohnson commented 3 months ago

Ok, ready to be reviewed!

jasonacox commented 3 months ago

Looks good @DerickJohnson ! Thanks! 🙏

I'll add release notes and start the merge.