Added SocketDevice - Githubissues

Felix-Pi commented 2 years ago

Added SocketDevice to receive power consumption data

jasonacox commented 2 years ago

Brilliant! Thanks @Felix-Pi ! Great work on the extension.

I merged this but suggest you consider adding a few things:

There are 3.1 and 3.3 devices that use DPS 4, 5 and 6 for current, power and voltage (see here). I have some of these. You could add some basic logic to check for DPS 18 and if it isn't there, use 4, 5 and 6.
Error handling for non-energy plugs - If a device does not show up with the needed DPS values, instead of allowing a KeyError exception, catch it and respond back with an error indicating the device does not appear to have energy measurement (see the error_json() function if you want to use it for a response).

Felix-Pi commented 2 years ago

Thank you for your input! I'll look into it as soon as possible 👍🏼

jasonacox commented 2 years ago

@Felix-Pi your code is now live in v1.6.6..

Thanks again for your help!

jasonacox / tinytuya