search

jasonaowen / recurse-community-portfolio

Discover all the things Recursers have built!
https://portfolio.recurse.com/
GNU Affero General Public License v3.0
15 stars 6 forks source link

Visual changes #94

Closed tvieregge closed 5 years ago

tvieregge commented 5 years ago

Styling (HTML and CSS) changes. It affects the whole site, but mostly the changes were to list.html.

I ran prittier on list.html, so the changes got a bit inflated there.

jasonaowen commented 5 years ago

I deployed this to https://portfolio-staging.recurse.com (which the Heroku deployment above hints at); this this branch doesn't include the application server changes, so logging in is broken at the moment.

The changes are beautiful! More detailed review to come, but here's a few before and after screenshots:

Recent (before)

Recent (after)

Tag (before)

Tag (after)

tvieregge commented 5 years ago

Prettier was just run a command line tool. It was mentioned to me that running it as a pre-commit hook worked well.

I agree that the whitesspace changes would have been better beforehand, but prettier does changes over multiple lines, making it pretty hard to reorder stuff. Basically the whole file become a change. Maybe we should run it across the whole project then make it a standard?

tvieregge commented 5 years ago

This got left by the wayside for a bit, but I went over the testing again and everything seems good.

Let me know if there's any other changes you'd like, and if not I'll clean up the commits for merging.

tvieregge commented 5 years ago

@jasonaowen Glad to help! And no problem, we both had lots going on the last little while.

I made those changes, gave it a quick look over with my test db and squashed the commits. Should be good to go!

jasonaowen commented 5 years ago

@tvieregge awesome, thank you! Merging!