search

jasonbhart / mmh

"Meet Me Here" website to help you organize ad hoc events with your friends on the fly
0 stars 0 forks source link

Geo error when using 'Meet Me Here' via moble #510

Closed pixiewillow closed 8 years ago

pixiewillow commented 8 years ago

I got the following error while trying to use "Meet Me Here' at a restaurant in Santa Clara. Jason got the same error while trying to use 'Meet Me Here' while in Mountain View.

screenshot_2016-01-06-11-50-48

jasonbhart commented 8 years ago

@loipl we also need to investigate why GPS was not used as this should be preferable over geoip, especially on a mobile device.

loipl commented 8 years ago

We only need to detect if the country is US or other. If using GPS, we will need to get coordinates from browsers, then send it to GG map API to get the country name, which is more complicated. So Geoip is a simpler & working solution.

Will check Maxmind & see if we can change to use it.

jasonbhart commented 8 years ago

Geoip is always going to be less accurate on a mobile device On Jan 13, 2016 5:59 PM, "Pham Le Loi" notifications@github.com wrote:

We only need to detect if the country is US or other. If using GPS, we will need to get coordinates from browsers, then send it to GG map API to get the country name, which is more complicated. So Geoip is a simpler & working solution.

Will check Maxmind & see if we can change to use it.

— Reply to this email directly or view it on GitHub https://github.com/jasonbhart/mmh/issues/510#issuecomment-171500449.

loipl commented 8 years ago

Badly realized the country_code information is available from Yelp API. No GPS or Geoip needed.

pixiewillow commented 8 years ago

Closing ticket for now, will reopen if we see this issue again.