jasonbhart / mmh

"Meet Me Here" website to help you organize ad hoc events with your friends on the fly
0 stars 0 forks source link

Refactor session + user service. #560

Open diepbuihuu opened 8 years ago

diepbuihuu commented 8 years ago

Current session + user service is not working effectively which cause pages to init slowly. We need to refactor these services as such:

jasonbhart commented 8 years ago

Diep- can you please estimate the number of hours required to make this refactor?

On Wed, Jan 27, 2016 at 12:41 AM, diepbuihuu notifications@github.com wrote:

Current session + user service is not working effectively which cause pages to init slowly. We need to refactor these services as such:

  • Session service should rely on local data instead of calling firebase for data as sessionService.ready() is the condition for most pages to init.
  • user service should enable creating user object from both local data and remoted data.
  • user object created by session service and user service should be the same to avoid calling firebase multiple time for the same object.
  • enable partial caching. Only store most important data in cookie as maximum size for cookie is only 4KB. Need to update cookie everytime user (location, setting, ...) is updated. Remove it upon logging out.

— Reply to this email directly or view it on GitHub https://github.com/jasonbhart/mmh/issues/560.

[image: photo] Jason B. Hart m:(408) 646-4677 | e:jasonbhart@gmail.com http://facebook.com/jasonbhart http://www.linkedin.com/in/jasonbhart http://twitter.com/jasonbhart

diepbuihuu commented 8 years ago

I think It would take 3-4 days.