search

jasonbhart / mmh

"Meet Me Here" website to help you organize ad hoc events with your friends on the fly
0 stars 0 forks source link

GPS warning when in Facebook mobile browser #584

Open jasonbhart opened 8 years ago

jasonbhart commented 8 years ago

Need additional logic to handle scenario when in Facebook mobile browser and Facebook location sharing/services are disabled by the user or otherwise not available. We need to not only change the warning but also change our logic in terms of where we are pulling locality information from.

screenshot_2016-01-29-21-31-13

loipl commented 8 years ago

@jasonbhart i tested on my iphone & current logic is still working with enabling/disabling location service. In this ticket, do you want to add instruction to enable GPS for Ios/Android devices?

jasonbhart commented 8 years ago

The problem is in the Facebook browser, it is not about enabling/disabling GPS its about enabling Location Services (?) option in Facebook.

loipl commented 8 years ago

No, on Facebook browser, we still use the location of the device. If it's disabled, then we show the warning. If it's enabled, user will be asked to provide their confirmation as normal. (Tested on my iphone & Diep's android)

Maybe we will need to add this same guild into our document? https://www.facebook.com/help/275925085769221

jasonbhart commented 8 years ago

It is a different context for the user. The GPS is not what needs to be changed its the location service in Facebook which changes this setting in this case, right? You must think of this from a stupid user point of view. On Feb 4, 2016 8:24 PM, "Pham Le Loi" notifications@github.com wrote:

No, on Facebook browser, we still use the location of the device. If it's disabled, then we show the warning. If it's enabled, user will be asked to provide their confirmation as normal. (Tested on my iphone & Diep's android)

Maybe we will need to add this same guild into our document? https://www.facebook.com/help/275925085769221

— Reply to this email directly or view it on GitHub https://github.com/jasonbhart/mmh/issues/584#issuecomment-180187912.

loipl commented 8 years ago

This is working on IOS because the facebook app is using the option of device's GPS. On Android, there is a separate option to enable/disable location service of the Facebook app itself. Still not sure how can we get this setting from Javascript...

loipl commented 8 years ago

@jasonbhart, @edgeprod do you have any suggestion on how to pull locality from Facebook app's location service option on Android?