jasonbio / reddit-shell

web based linux shell emulator that allows you to browse reddit via command line
https://redditshell.com/
GNU General Public License v3.0
432 stars 38 forks source link

Can't scroll #11

Closed zethon closed 6 years ago

zethon commented 6 years ago

I use https://redditshell.com/ often when I'm in the office since it's more innocuous but a few months ago I noticed that I was no longer able to scroll. I figured this had something to do with my work's firewall since weird things always happen because of the firewall. I decided to use https://redditshell.com/ tonight while I'm out and about (and being lame and using my laptop at a bar) and sure enough, I'm unable to scroll. WTF?

BTW: Chrome Version 62.0.3202.94 (Official Build) (64-bit) OSX: 10.11.6

nikwilliamson commented 6 years ago

Just added a PR for a fix for this. https://github.com/jasonbio/reddit-shell/pull/12

jcubic commented 6 years ago

Better would be to update jQuery Terminal because I made mistake and use browser sniff to detect Google Chrome. Google was using html as scroll element and they changed their mind it's now the same as in other browsers.

The other issue that will not be fixed unless you update the library is scroll to bottom on keypress.

jasonbio commented 6 years ago

This has been fixed with 7841b82