search

jasonblais / mattermost-community

Repository for tracking community-related tickets.
Apache License 2.0
2 stars 0 forks source link

Update PULL_REQUEST_TEMPLATE.md for Mattermost repos #38

Open jasonblais opened 5 years ago

jasonblais commented 5 years ago

The pull request template has a few issues:

  1. Not everyone removes the filler texts, making the PR description confusing when submitted. We should instead use the following format to describe expectations within the pull request template
<!--
Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog
-->

These notes will then not appear in the PR description regardless of whether the community member removes them or not.

Finally, the checklist for a PR is outdated, and some items aren't relevant. We should reference, and update, the contribution checklist here https://developers.mattermost.com/contribute/getting-started/contribution-checklist/

hanzei commented 5 years ago

See https://github.com/mattermost/mattermost-server/pull/10142