search

jasoncfoster / intro-data-capstone-biodiversity

0 stars 0 forks source link

Add line breaks to increase code readability #2

Open sen1 opened 6 years ago

sen1 commented 6 years ago

https://github.com/jasoncfoster/intro-data-capstone-biodiversity/blob/14bfe8a623819dc28569ed193253601ea2e3198e/Capstone20171219-JasonFoster/biodiversity.py#L113

A long line of code like this is very hard to read. Please add line breaks. The PEP8 standard says no more than 79 characters per line. https://www.python.org/dev/peps/pep-0008/#maximum-line-length

Code styling is not something we strictly followed in this course. However, it is very important. So I would do:

protection_counts = species.groupby('conservation_status')\
    .scientific_name.nunique().reset_index()\
    .sort_values(by='scientific_name')
jasoncfoster commented 6 years ago

Point taken and thank you.