search

jasoncheng / dica

This is a very simple Friendica android client, wrote by Android Kotlin
GNU General Public License v3.0
14 stars 2 forks source link

Minor UI Refresh and Help Page #144

Closed imattau closed 5 years ago

imattau commented 5 years ago

UI Refresh and initial development of a Help page using a WebView

jasoncheng commented 5 years ago

I'm so happy that @imattau join us to the big help on DiCa, i reviewed commits, lot of changes (Compose Dialog / TitleBar..and more), thanks for you hard work, and i like it, appreciate,

From your commits, look like you work on android development / design for years, am i right? i believe DiCa will getting better and better since you join.

some question list below.

  1. Please reset app/build.gradle to original develop commit, because it's you workspace directory , should i put release key on Github? or just mail key to you. BTW, signingConfigs.jason, i would change to signingConfigs.dica

  2. Help page's floating email icon click action, could you link to DiCa support forum, or you have better idea on this?

  3. Help page's variable (dataString) should put it in assets/ or in locale ; BTW, this page is good to have :)

  4. Status title bar background color, i'm not get used to after testing a hours, but it's not fair, because i not a professional, do you mind i build a temp APK file, and put it in DiCa forum, let user decide? is that okay?

imattau commented 5 years ago

Hi Jason,

Thanks for your feedback!

  1. I've restored your config settings in the build file. + my own key so Android Studio would build.

  2. Can make it link to the forum if you like, or could just remove it and have all the links inside the webview.

  3. Moved to dataString value to @string/menu_help_text asset. It was hardcoded before because of a compile issue.

  4. Can change the colour if you like, maybe to a lighter colour? I think it just needed something to help seperate the posts.

I've also add a Search link in the menu; which opens the existing SearchActivity.

imattau commented 5 years ago

If you can send me the signing key, that would be helpful. imatt.au@protonmail.com

ghost commented 5 years ago

I am glad and grateful to have imattau on board who is also an Andriod developer and helps to advance Friendca. I preferred DiCa from the beginning because it was clear and intuitive to use from the very first minute, and so it has to stay that way. The changes sound good and I'm ready for testing.

@imattau are you already registered on meld.de?

jasoncheng commented 5 years ago

@imattau https://abhiandroid.com/androidstudio/add-local-html-file-android-studio.html

imattau commented 5 years ago

@imattau https://abhiandroid.com/androidstudio/add-local-html-file-android-studio.html

Even easier! And now could include images easily...

jasoncheng commented 5 years ago

If you can send me the signing key, that would be helpful. imatt.au@protonmail.com

Sent

jasoncheng commented 5 years ago

https://photos.app.goo.gl/dt1Kb9vszk7YYvSH9 2019-01-27 9 04 20

Remove blank space, below editview

imattau commented 5 years ago

@jasoncheng found the problem. There was a maxline set to 6...

jasoncheng commented 5 years ago

each status bar background color(#e8eaf6 ) and rounded corner (as light as you can)

materializecss.com/color.html

jasoncheng commented 5 years ago

@jasoncheng found the problem. There was a maxline set to 6...

Please do not set too height to cover background message, sometimes we need to see background text , for easy reply a comment

imattau commented 5 years ago

@copiis No, on a different instance.

jasoncheng commented 5 years ago

Please, next time, do not push so many feature and enhancement in a same PR; I would prefer pick below list first for next release.

**1. Localization correction

  1. Help page
  2. Action Icon without text** ( Like / Retweet / Comments ..)

The rest part. i would keep it original look like for now, I think it's change too much, such as :

In this situation, I really don't know how to take this PR, it's complicated; I would take PR and modify some enhancement rollback to originally.

then marge into develop branch, once I done, let's move forward on it.

Hope you understand.

Recently, busy for my new job, will take this action next week (during my Chinese new year vocation ), or would you mind submit a new PR include just those there features that i list above ?

imattau commented 5 years ago

Only think not changed it the colours.

jasoncheng commented 5 years ago

Only think not changed it the colours.

revert original comment dialog too, thanks