search

jasoncoon / esp8266-fastled-webserver

GNU General Public License v3.0
713 stars 359 forks source link

added: settings for customizing time zone and DST #191

Closed AlexxBoo closed 2 years ago

AlexxBoo commented 3 years ago

I went ahead and added all Time Zones for selection in a dropdown list, as well as a setting for daylight saving.

jasoncoon commented 3 years ago

Awesome! I've been debating doing that, with a new field type and just putting the tz list in the web app. But this works as well, thank you!

AlexxBoo commented 3 years ago

Yeah, I did not think of this solution. 🤔 Having the list in the web-app would probably relieve communication to the backend, and building and maintaining the list would not use up program memory and processing resources. Hence that would arguably be the proper way I guess. But on the other hand then the web-app would have to deal with validation and value ranges. There would be no way for the backend to figure if a provided value would be valid, right?

henrygab commented 2 years ago

@AlexxBoo ... I think we should close this PR, in view of #213. Let us know if you disagree.

AlexxBoo commented 2 years ago

Hi @henrygab, thank you so much for the feedback (sorry for my late response...) I'm totally fine with closing this PR, seeing that the initially intended functionality is properly finding its way into the software.