search

jasoncoon / esp8266-fastled-webserver

GNU General Public License v3.0
712 stars 360 forks source link

[DRAFT] Validate pattern/palette index with hash #234

Open henrygab opened 2 years ago

henrygab commented 2 years ago

fixes #230 ... at least in part ... by ensuring that a hash of the name for the palette and pattern match the value stored in EEPROM.

Used MurMurHash3 for speed and applicability to hashing strings in non-security context.

henrygab commented 2 years ago

@jasoncoon -- Just wanted to see if there's interest in either of the two parts of this:

  1. using hash to validate name + index match
  2. default patterns being listed by name (rather than index)

I've not yet figured a way to reliably debug on ESP8266, which is the only known issue holding this up. Testing is non-trivial.

jasoncoon commented 2 years ago

I wasn't overly concerned about either of these problems, but I have no problem with fixing them or this solution. Thanks!