search

jasondavies / bloomfilter.js

JavaScript bloom filter using FNV for fast hashing
http://www.jasondavies.com/bloomfilter/
BSD 3-Clause "New" or "Revised" License
759 stars 79 forks source link

License clarification #27

Closed jinwoo closed 6 years ago

jinwoo commented 6 years ago

First of all, thank you for the great implementation of Bloom Filter. We're using this package from our h2-auto-push package, and it's working great.

But I want to make sure we have no license problems by depending on this package. Your LICENSE file looks similar to BSD-3-Clause but not quite the same. Can I understand it as BSD-3-Clause?

If my understanding is correct, can you please put the license info into your package.json? Because it is missing, the npm page says "license: none": https://www.npmjs.com/package/bloomfilter. It'll be as simple as adding this line:

{ "license" : "BSD-3-Clause" }

https://docs.npmjs.com/files/package.json#license

Thank you!

pchaigno commented 6 years ago

Replacing the license file with one of those from https://choosealicense.com/ would also allow GitHub to recognize and display it.

jinwoo commented 6 years ago

Awesome. Thanks, @jasondavies , for the super-quick fix!

jasondavies commented 6 years ago

You're welcome. Thanks for reporting the issue!