search

jasondavies / d3-cloud

Create word clouds in JavaScript.
https://www.jasondavies.com/wordcloud/
Other
3.82k stars 1.07k forks source link

upgrade to d3-v4 plugin structure #109

Closed sly7-7 closed 7 years ago

sly7-7 commented 7 years ago

related #107

robokozo commented 7 years ago

Maybe this could be published to npm separately?

sly7-7 commented 7 years ago

@robodude I've just publish d3-v4-cloud . You can have a try.

robokozo commented 7 years ago

Gave it a try and it seems to work quite well so far, thanks! :)

jasondavies commented 7 years ago

Is this a purely cosmetic change to the code structure, or is there a functional reason too?

aknuds1 commented 7 years ago

@jasondavies Good question, I was wondering about the reason for moving the code too.

simonmcl commented 7 years ago

I'm quite new to d3 and angular, but i'm having a lot of trouble trying to integrate this package into Angular 2 with d3v4. Code samples online just keep telling me that "layout" can't be found on element d3 for this code:

d3.layout.cloud()

I'm guessing that this module system has been changed between d3v3 and d3v4? I think it would be worth re-looking at this pull request and updating the DefinitelyTyped types entry d3.cloud.layout

@sly7-7 would you be able to create an @types (e.g. https://www.npmjs.com/package/@types/d3.cloud.layout ) for your module as Angular2 doesn't know how to process it?

sly7-7 commented 7 years ago

Unfortunately I m sick for now, and can't do anything (actually I don't even have a computer). I could eventually take a look at this in two weeks (I hope so...)

Le 2 févr. 2017 10:42, "Simon McLoughlin" notifications@github.com a écrit :

I'm quite new to d3 and angular, but i'm having a lot of trouble trying to integrate this package into Angular 2 with d3v4. Code samples online just keep telling me that "layout" can't be found on element d3 for this code:

d3.layout.cloud()

I'm guessing that this module system has been changed between d3v3 and d3v4? I think it would be worth re-looking at this pull request and updating the DefinitelyTyped types entry d3.cloud.layout

@sly7-7 https://github.com/sly7-7 would you be able to create an @types (e.g. https://www.npmjs.com/package/@types/d3.cloud.layout ) for your module as Angular2 doesn't know how to process it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jasondavies/d3-cloud/pull/109#issuecomment-276911092, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvfZY9M7jb-Vyt8r71T11buC0XvqTXlks5rYaUfgaJpZM4KjZBg .