search

jasongaare / react-native-walkthrough-tooltip

An inline wrapper for calling out React Native components via tooltip
MIT License
620 stars 184 forks source link

Highlight a complete view or component #102

Open obadiaspelembe opened 3 years ago

obadiaspelembe commented 3 years ago

I would like to suggest the adding of the line background: "#FFF" on tooltip.js file to highlight a complete component without this line i didn't find the complete highligh effect if i pass a complex component as children image

Result before adding the line image

After adding the result found is this: image

Thank you

jasongaare commented 3 years ago

Hi 👋🏼

I like you suggestion - would you mind opening a PR?

A couple thing here too,

  1. Could you make this optional? Aka adding it as a boolean prop?
  2. Will you please update the README as well with new information about it
obadiaspelembe commented 3 years ago

Hi, Yes i do. And a noted that a possible solution was already added but i think is waiting for a approval. As you can see below, Justyna Sowinska added a new prop childrenWrapperStyle that could be used as solution for this issue. Let me know if this is still in development ou test step so maybe i could use it or you will need me to implement specifically the prop wrapper Background Color? Thank you image

Ayusch commented 3 years ago

@obadiaspelembe childrenWrapperStyle didn't work for me. This prop isn't present in the latest version 1.1.11

How did you solve it ?

ayusch-apps-curefit commented 3 years ago

@jasongaare Can you please release the version with the prop childrenWrapperStyle added ?