search

jasongaare / react-native-walkthrough-tooltip

An inline wrapper for calling out React Native components via tooltip
MIT License
610 stars 182 forks source link

React v17 #158

Closed jerryk1925 closed 2 years ago

jerryk1925 commented 2 years ago

Hi, can you upgrade peerDep to 17 version React plz

SharpMobileCode commented 2 years ago

Same for me. This is a great tool, but it's downgrading my version of React from v17 to v16.

jasongaare commented 2 years ago

hi! could you open a PR to show me exactly what you mean? thanks!

jerryk1925 commented 2 years ago

Hi, in your package.json file you have 

  "peerDependencies": {
    "@types/react": "^16.8.24"
  },

And i can't update react in my project because i have problem with different version in my version react and types of react with peerDep your package Can you update this package to react 17 version or change peerDep for example 

  "peerDependencies": {
    "@types/react": "^16.8.24" || '17'
  },
jasongaare commented 2 years ago

solved by https://github.com/jasongaare/react-native-walkthrough-tooltip/pull/146#pullrequestreview-1025062787