jasongaare / react-native-walkthrough-tooltip

An inline wrapper for calling out React Native components via tooltip
MIT License
610 stars 182 forks source link

Fixes positioning issue #118 (add horizontalAdjustment prop) #162

Closed topherPedersen closed 1 year ago

topherPedersen commented 2 years ago

This pull requests adds a new prop, horizontalAdjustment, similar to the existing topAdjustment prop, which allows horizontal adjustment of the highlighted child view should the library get the alignment wrong. I ran into the same issue described in Issue #118 yesterday, a horizontal alignment problem, and created this new prop to solve this issue in my organization's app.

doug-sheridan commented 1 year ago

@jasongaare , I think this is a good solution to Issue #118 and should be accepted into this library 👍

mehakenlume commented 1 year ago

when is it going to be merged, please so it as soon as possible.

jasongaare commented 1 year ago

Seems reasonable!

sayo96 commented 1 year ago

@jasongaare This still doesn't solve the problem. All I wanted was the tooltip to be position above the element it wraps but tooltip appears a bit towards the left instead.

Screenshot 2023-08-23 at 5 07 29 pm