jasongaare / react-native-walkthrough-tooltip

An inline wrapper for calling out React Native components via tooltip
MIT License
610 stars 182 forks source link

React 18 Support #165

Open nbdaaron opened 1 year ago

nbdaaron commented 1 year ago

Can this library add support for React 18? Thanks!

dcsan commented 1 year ago

would this be as simple as bumping the react dependency? or is there an incompatibility?

https://github.com/jasongaare/react-native-walkthrough-tooltip/blob/master/package.json#L40

estmau commented 1 year ago

Please, add support for React > 18, this librsry cant install in react narive >.70

VincentCrete commented 1 year ago

I approve this.

miyamaework commented 1 year ago

I used overrides to solve the problem as this is a version specification issue with the @types/react package.

{
  "name": "my-app",
  "dependencies": {
    "react": "18.1.0",
    "react-native": "0.70.5",
    "react-native-walkthrough-tooltip": "1.5.0"
  },
  "devDependencies": {
    "@types/react": "18.0.24",
    "@types/react-native": "0.70.5"
  },
  "overrides": {
    "react-native-walkthrough-tooltip": {
      "@types/react": "18.0.24"
    }
  },
SamJbori commented 1 year ago

Update?