search

jasongaare / react-native-walkthrough-tooltip

An inline wrapper for calling out React Native components via tooltip
MIT License
620 stars 182 forks source link

onClose() is not passing event data to callback function #196

Open r-rouse opened 5 months ago

r-rouse commented 5 months ago

I am trying to pass event data to my call back function when closing tooltip.

such as onClose={(e) => callBack(e)}. I would like to be able to access pageX to know which tooltip to make visible next. The onClose() is being called but event is undefined.

This worked previously on version 1.2.0 I have since upgraded react-native: "react-native-gesture-handler": "2.16.0", "react-native": "^0.73.0",

r-rouse commented 5 months ago

I was able to solve this problem by adding this in to tooltip.js:

Screenshot 2024-05-03 at 1 10 35 PM

brianangulo commented 2 months ago

Isn't this resolved?

r-rouse commented 2 months ago

I have a PR request submitted with a resolution: https://github.com/jasongaare/react-native-walkthrough-tooltip/pull/197

I believe the issue was introduced by: https://github.com/jasongaare/react-native-walkthrough-tooltip/pull/149

On Fri, Jul 19, 2024 at 7:51 AM Brian Angulo @.***> wrote:

Isn't this resolved?

— Reply to this email directly, view it on GitHub https://github.com/jasongaare/react-native-walkthrough-tooltip/issues/196#issuecomment-2239396422, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWLR26QTSRP6NMDN7RVYLGTZNERXVAVCNFSM6AAAAABHGAI3ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZGM4TMNBSGI . You are receiving this because you authored the thread.Message ID: @.*** com>

-- Randall Rouse in https://www.linkedin.com/in/randall-rouse/ (720) 930-1314