update scope for new ink version

jasongilman / proto-repl

A Clojure Development Environment package for the Atom editor

https://atom.io/packages/proto-repl

MIT License

565 stars 50 forks source link

update scope for new ink version #252

Closed pfitzseb closed 7 years ago

pfitzseb commented 7 years ago

This is an update to ensure proto-repl's compatibility with the next ink version. https://github.com/JunoLab/atom-ink/pull/127 broke the hack of adding a class to the result directly via r.view.classList.add and introduced a scope keyword for the Result constructor instead.

It would also make sense to adapt your stylesheets to use the adaptive width introduced in the abovementioned PR. Should you run into any troubles with ink master feel free to ping me. :)

pedro-w commented 7 years ago

@jasongilman would it be possible to make Ink a required dependency now? The alternative code path that doesn't use Ink for the REPL seems a bit fragile (i.e. #229 seems to have re-appeared after being fixed)

pfitzseb commented 7 years ago

Alright, we've added a shim to work around this in the new ink release: https://github.com/JunoLab/atom-ink/commit/cb9bc4de8282ddbc3e4cb6d4b77c5c45eb9c8d37 Would still be nice if this could be merged :)